From 528afafcda70fe88320d98db59c6190f4b4ba13b Mon Sep 17 00:00:00 2001 From: Gregor Lohaus Date: Sun, 31 May 2026 19:52:24 +0200 Subject: [PATCH] no next floating pane keyboard shortcut --- README.md | 2 -- config.example.toml | 3 +-- src/main/java/com/gregor/jprototerm/AppConfig.java | 2 -- src/main/java/com/gregor/jprototerm/Compositor.java | 8 -------- src/main/java/com/gregor/jprototerm/Main.java | 3 --- src/main/java/com/gregor/jprototerm/Tab.java | 10 ---------- 6 files changed, 1 insertion(+), 27 deletions(-) diff --git a/README.md b/README.md index ae356e1..59dd83d 100644 --- a/README.md +++ b/README.md @@ -106,7 +106,6 @@ navigate_up = "ALT+K" navigate_right = "ALT+L" toggle_floating = "ALT+F" new_pane = "ALT+N" -next_floating = "ALT+F12" close_pane = "ALT+X" new_tab = "ALT+A" previous_tab = "ALT+SHIFT+H" @@ -121,7 +120,6 @@ open_scrollback = "ALT+S" - `Alt+n`: new pane — a floating pane when floating panes are shown, otherwise a new tiled pane (tiled panes are split equally across the width) - `Alt+f`: show or hide all floating panes -- `Alt+F12`: cycle floating panes - `Alt+x`: close the active pane; closing a tab's last pane closes the tab, and closing the last pane of the last tab quits - `Alt+a`: new tab diff --git a/config.example.toml b/config.example.toml index ddd7b04..0016e97 100644 --- a/config.example.toml +++ b/config.example.toml @@ -25,8 +25,7 @@ navigate_down = "ALT+J" navigate_up = "ALT+K" navigate_right = "ALT+L" toggle_floating = "ALT+F" -new_floating = "ALT+SHIFT+F" -next_floating = "ALT+F12" +new_pane = "ALT+N" close_pane = "ALT+X" open_font_selector = "ALT+T" open_scrollback = "ALT+S" diff --git a/src/main/java/com/gregor/jprototerm/AppConfig.java b/src/main/java/com/gregor/jprototerm/AppConfig.java index 2424662..0a3f6c9 100644 --- a/src/main/java/com/gregor/jprototerm/AppConfig.java +++ b/src/main/java/com/gregor/jprototerm/AppConfig.java @@ -37,7 +37,6 @@ public record AppConfig( "navigate_right", "toggle_floating", "new_pane", - "next_floating", "close_pane", "new_tab", "previous_tab", @@ -96,7 +95,6 @@ public record AppConfig( Map.entry("navigate_right", KeyBinding.parse("ALT+L")), Map.entry("toggle_floating", KeyBinding.parse("ALT+F")), Map.entry("new_pane", KeyBinding.parse("ALT+N")), - Map.entry("next_floating", KeyBinding.parse("ALT+F12")), Map.entry("close_pane", KeyBinding.parse("ALT+X")), Map.entry("new_tab", KeyBinding.parse("ALT+A")), Map.entry("previous_tab", KeyBinding.parse("ALT+SHIFT+H")), diff --git a/src/main/java/com/gregor/jprototerm/Compositor.java b/src/main/java/com/gregor/jprototerm/Compositor.java index 17b263e..6874a73 100644 --- a/src/main/java/com/gregor/jprototerm/Compositor.java +++ b/src/main/java/com/gregor/jprototerm/Compositor.java @@ -111,14 +111,6 @@ public final class Compositor { markSceneDirty(); } - public void nextFloatingPane() { - if (isEmpty()) { - return; - } - currentTab().nextFloatingPane(); - markSceneDirty(); - } - public void closeActivePane() { if (isEmpty()) { return; diff --git a/src/main/java/com/gregor/jprototerm/Main.java b/src/main/java/com/gregor/jprototerm/Main.java index 87b5548..ce9d562 100644 --- a/src/main/java/com/gregor/jprototerm/Main.java +++ b/src/main/java/com/gregor/jprototerm/Main.java @@ -70,9 +70,6 @@ public final class Main extends Application { } else if (config.keybindings().get("new_pane").matches(event)) { compositor.createPane(); event.consume(); - } else if (config.keybindings().get("next_floating").matches(event)) { - compositor.nextFloatingPane(); - event.consume(); } else if (config.keybindings().get("close_pane").matches(event)) { compositor.closeActivePane(); event.consume(); diff --git a/src/main/java/com/gregor/jprototerm/Tab.java b/src/main/java/com/gregor/jprototerm/Tab.java index 6ab1f28..ddc53e1 100644 --- a/src/main/java/com/gregor/jprototerm/Tab.java +++ b/src/main/java/com/gregor/jprototerm/Tab.java @@ -153,16 +153,6 @@ final class Tab implements AutoCloseable { } } - void nextFloatingPane() { - if (floating.isEmpty()) { - createFloatingPane(); - return; - } - floatingVisible = true; - int current = floating.indexOf(active); // -1 when the active pane is tiled - setActive(floating.get((current + 1 + floating.size()) % floating.size())); - } - void closeActivePane() { TerminalPane closing = active; boolean wasFloating = floating.remove(closing);