gregor/jprototerm
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "snap repaint clear/fill to integer pixels to kill seam bars"

Browse Source 
This reverts commit 6613f1f746.
This commit is contained in:
Gregor Lohaus
2026-05-31 21:58:15 +02:00
parent 6613f1f746
commit 8e060b27ca
1 changed files with 6 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/main/java/com/gregor/jprototerm/TerminalPaneNode.java
View File

@@ -825,14 +825,6 @@ final class TerminalPaneNode extends Region {
return Math.ceil(TerminalMetrics.PADDING + (row + 1) * metrics.lineHeight()); return Math.ceil(TerminalMetrics.PADDING + (row + 1) * metrics.lineHeight());
} }
// Left edge of a column, snapped to a whole device pixel. Both the clearRect and the
// background fillRect go through this so a run's edges land on integer pixels: at a
// fractional boundary clearRect clears the edge pixel fully while fillRect would only
// cover it partially, leaving a thin transparent (black) seam through the line.
private double columnX(int column) {
return Math.round(TerminalMetrics.PADDING + column * metrics.cellWidth());
}
private void repaintColumns(GraphicsContext gc, RenderRow row, int startColumn, int endColumn) { private void repaintColumns(GraphicsContext gc, RenderRow row, int startColumn, int endColumn) {
if (endColumn < startColumn) { if (endColumn < startColumn) {
return; return;
@@ -844,8 +836,8 @@ final class TerminalPaneNode extends Region {
double contentTop = TerminalMetrics.PADDING + row.row() * lineHeight; double contentTop = TerminalMetrics.PADDING + row.row() * lineHeight;
double localCellTop = contentTop - rowTop; double localCellTop = contentTop - rowTop;
double baseline = TerminalMetrics.PADDING + metrics.baselineOffset() + row.row() * lineHeight - rowTop; double baseline = TerminalMetrics.PADDING + metrics.baselineOffset() + row.row() * lineHeight - rowTop;
double x = columnX(startColumn); double x = TerminalMetrics.PADDING + startColumn * cellWidth;
double width = columnX(endColumn + 1) - x; double width = (endColumn - startColumn + 1) * cellWidth;
gc.clearRect(x, 0.0, width, canvas.getHeight()); gc.clearRect(x, 0.0, width, canvas.getHeight());
if (startColumn == 0) { if (startColumn == 0) {
@@ -853,7 +845,7 @@ final class TerminalPaneNode extends Region {
gc.fillRect(0.0, 0.0, TerminalMetrics.PADDING, canvas.getHeight()); gc.fillRect(0.0, 0.0, TerminalMetrics.PADDING, canvas.getHeight());
} }
if (endColumn >= row.cells().size() - 1) { if (endColumn >= row.cells().size() - 1) {
double contentRight = columnX(row.cells().size()); double contentRight = TerminalMetrics.PADDING + row.cells().size() * cellWidth;
gc.setFill(rowEdgeBackground(row, false)); gc.setFill(rowEdgeBackground(row, false));
gc.fillRect(contentRight, 0.0, canvas.getWidth() - contentRight, canvas.getHeight()); gc.fillRect(contentRight, 0.0, canvas.getWidth() - contentRight, canvas.getHeight());
} }
@@ -868,7 +860,7 @@ final class TerminalPaneNode extends Region {
return; return;
} }
double contentLeft = TerminalMetrics.PADDING; double contentLeft = TerminalMetrics.PADDING;
double contentRight = columnX(columns); double contentRight = contentLeft + columns * metrics.cellWidth();
gc.setFill(rowEdgeBackground(row, true)); gc.setFill(rowEdgeBackground(row, true));
gc.fillRect(0.0, 0.0, contentLeft, bandHeight); gc.fillRect(0.0, 0.0, contentLeft, bandHeight);
gc.setFill(rowEdgeBackground(row, false)); gc.setFill(rowEdgeBackground(row, false));
@@ -922,12 +914,11 @@ final class TerminalPaneNode extends Region {
if (background == null || endColumn < startColumn) { if (background == null || endColumn < startColumn) {
return; return;
} }
double left = columnX(startColumn);
gc.setFill(background); gc.setFill(background);
gc.fillRect( gc.fillRect(
left, TerminalMetrics.PADDING + startColumn * cellWidth,
localCellTop, localCellTop,
columnX(endColumn + 1) - left, (endColumn - startColumn + 1) * cellWidth,
lineHeight); lineHeight);
} }